[PATCH] D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests
Lei Huang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 10 13:00:43 PDT 2020
lei accepted this revision.
lei added a comment.
This revision is now accepted and ready to land.
LGTM
Please address the nits on commit.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1022
+ def XSCVUQQP : X_VT5_XO5_VB5<63, 3, 836, "xscvuqqp", []>;
+ def XSCVSQQP: X_VT5_XO5_VB5<63, 11, 836, "xscvsqqp", []>;
}
----------------
nit: looks like there's a mix of diff spacings in the section above. Please keep it consistent. It should be `def NAME : DEF`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83516/new/
https://reviews.llvm.org/D83516
More information about the cfe-commits
mailing list