[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 10 11:12:40 PDT 2020


arsenm added a comment.

In D82087#2140778 <https://reviews.llvm.org/D82087#2140778>, @sameerds wrote:

> The documentation for HIP __ballot seems to indicate that the user does not have to explicitly specify the warp size. How is that achieved with these new builtins? Can this  be captured in a lit test here?
>
> https://github.com/ROCm-Developer-Tools/HIP/blob/master/docs/markdown/hip_kernel_language.md#warp-vote-and-ballot-functions


I think if the language interface insists on fixing the wave size, then I think the correct solution is to implement this in the header based on a wave size macro (which we're desperately missing). The library implementation should be responsible for inserting the extension to 64-bit for wave32


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82087/new/

https://reviews.llvm.org/D82087





More information about the cfe-commits mailing list