[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

[David Goldman via Phabricator via cfe-commits]

dgoldman marked 5 inline comments as done and an inline comment as not done.
dgoldman added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:273
       Flags |= Rel::Underlying; // continue with the underlying decl.
+    } else if (const ObjCImplementationDecl *IID =
+                   dyn_cast<ObjCImplementationDecl>(D)) {
----------------
I think this is what you had in mind for findTarget, right? I guess though to be safe we should check D for nullptr before reporting below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83501/new/

https://reviews.llvm.org/D83501