[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

Daniel Grumberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 10 06:24:54 PDT 2020


dang added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:1246
   HelpText<"Enables an experimental new pass manager in LLVM.">;
+def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point">,
+  Group<f_clang_Group>, Flags<[CC1Option]>,
----------------
kpn wrote:
> dang wrote:
> > A bit late to the party, but can you mark this as `MarshallingInfoFlag<"LangOpts->ExpStrictFP", "false>` so that `if (Args.hasArg(OPT_fexperimental_strict_floating_point)) Opts.ExpStrictFP = true;` in CompilerInvocation.cpp gets generated automatically, we also get serializing the option for free this way.
> Assuming this patch makes it to the afternoon, how about I open a new review for this?
Sure no problem


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80952/new/

https://reviews.llvm.org/D80952





More information about the cfe-commits mailing list