[PATCH] D83546: [clangd] Fix hover crash on InitListExpr.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 10 06:17:52 PDT 2020


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/Hover.cpp:345
+    if (!ILE->isSemanticForm())
+      E = ILE->getSemanticForm();
+  }
----------------
kadircet wrote:
> shouldn't we put this before `QualType T = E->getType();` ?
ah, I think you're right. put it there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83546/new/

https://reviews.llvm.org/D83546





More information about the cfe-commits mailing list