[PATCH] D83511: [clangd] Config: If.PathExclude

Fri Jul 10 05:17:59 PDT 2020

sammccall marked an inline comment as done.
sammccall added a comment.

BTW I'm **not** planning to add Suffix/SuffixExclude in the immediate future, at least for clangd 11 people will have to use `PathMatch: '.*\.h'` or so. Sound OK?

================
Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:73
+  Frag.If.PathMatch.emplace_back("b.*");
+  Frag.If.PathExclude.emplace_back(".*r");
+  EXPECT_FALSE(compileAndApply());
----------------
hokein wrote:
> IIUC the semantic is: we only process the file `if (PathMatch("bar", "b.*") && !PathExclude("bar", ".*r"))`, PathExclude is true here, so we won't process the file.
Exactly. Added a small message to the assertion to clarify the intent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83511/new/

https://reviews.llvm.org/D83511