[PATCH] D82574: Merge TableGen files used for clang options

[Stephan Herhut via Phabricator via cfe-commits]

herhut added a comment.

Could you add the normalization back? This is in line with the comment to make sure the old and new files align.



================
Comment at: clang/include/clang/Driver/Options.td:3455
+  HelpText<"Specify target triple (e.g. i686-apple-darwin9)">,
+  MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::string">,
+  AlwaysEmit, Normalizer<"normalizeTriple">, DenormalizeString;
----------------
There is some explicit normalization missing here. In CC1Options.td this is

```
def triple : Separate<["-"], "triple">,
  HelpText<"Specify target triple (e.g. i686-apple-darwin9)">,
  MarshallingInfoString<"TargetOpts->Triple", "llvm::Triple::normalize(llvm::sys::getDefaultTargetTriple())", "std::string">,
  AlwaysEmit, Normalizer<"normalizeTriple">, DenormalizeString;
```

It seems the normalizer does not apply to the defaults and we now see a failure in `clang/unittests/Frontend/CompilerInvocationTest.cpp` for powerpc targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82574/new/

https://reviews.llvm.org/D82574