[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 9 19:32:41 PDT 2020


rjmccall added a comment.

I agree that avoiding the copy is best.  However, at the very least, if that function isn't going to handle the aggregate case correctly, it should assert that it isn't in it.

Otherwise this LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82513/new/

https://reviews.llvm.org/D82513





More information about the cfe-commits mailing list