[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 9 14:56:11 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.

LG with some nits



================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3287
+  if (Args.hasArg(OPT_fexperimental_strict_floating_point)) {
+    Opts.ExpStrictFP = true;
+  }
----------------
Delete redundant braces


================
Comment at: clang/test/CodeGen/fp-strictfp.cpp:12
+float fp_precise_1(float a, float b, float c) {
+// CHECK: _Z12fp_precise_1fff
+// CHECK: %[[M:.+]] = fmul float{{.*}}
----------------
Append a punctuation, i.e. `_Z12fp_precise_1fff:`


================
Comment at: clang/test/CodeGen/fp-strictfp.cpp:17
+}
+
+
----------------
Delete trailing empty lines


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80952/new/

https://reviews.llvm.org/D80952





More information about the cfe-commits mailing list