[PATCH] D82436: [clangd] Implement textDocument/foldingRange
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 9 14:55:11 PDT 2020
sammccall added a comment.
In D82436#2142631 <https://reviews.llvm.org/D82436#2142631>, @kbobyrev wrote:
> In D82436#2141953 <https://reviews.llvm.org/D82436#2141953>, @sammccall wrote:
>
> > Tests :-)
>
>
> I was hoping glorious DocumentSymbols super tested API would shield me from that :P
While the implementation is shared, a very small set of tests is fine. We should at least include some of the ranges that are "incorrect" that we want to fix.
> Didn't think of reasonable testing strategy but fair enough, will do!
I think you can literally just use an `Annotations` marked with all the ranges you expect.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82436/new/
https://reviews.llvm.org/D82436
More information about the cfe-commits
mailing list