[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 9 14:00:59 PDT 2020


rjmccall added a comment.

This seems fine.  I do wonder if the "real" bug is that this ought to be handled properly in EmitReturnFromThunk, but regardless, the fix seems acceptable.

Is there a similar bug with trivial_abi?  Should we have a test case for that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82513/new/

https://reviews.llvm.org/D82513





More information about the cfe-commits mailing list