[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 8 15:03:33 PDT 2020


njames93 added a comment.

I'm not a huge fan of using `error`, maybe `createError`, its used in many other parts of llvm, typically with static linkage.
Its definitely out of place in Logger, but there is no where else better for it to live short of a new file which seems overkill.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83419/new/

https://reviews.llvm.org/D83419





More information about the cfe-commits mailing list