[PATCH] D79842: [clang][Driver] Correct tool search path priority

Steven Wan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 8 14:06:52 PDT 2020


stevewan added a comment.

In D79842#2138857 <https://reviews.llvm.org/D79842#2138857>, @DavidSpickett wrote:

> Right, I see the issue.
>
> The code that gets the default triple name (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you have in cmake, not the actual default which you get in --version. We could "fix" this by doing so when we make the tool name as well, but this breaks whatever mips toolchain was using that. (their tools won't be mips-unknown-elf-<whatever>)
>
> So yes it looks up powerpc64le-linux-gnu but shows powerpc64le-unknown-linux-gnu. Can't go back to using cmake's value because on Mac OS, cmake has x86_64-darwin, clang has x86_64-darwin<version>. Writing to both is a short term option so I will try that and fold it into https://reviews.llvm.org/D83055. (will add you on review once I update it)
>
> (this whole default triple lookup should probably go but I'd really like to do that in its own commit)


Thanks. @DavidSpickett


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79842/new/

https://reviews.llvm.org/D79842





More information about the cfe-commits mailing list