[PATCH] D83402: ParsedAttrInfo: Change spelling to use StringRef instead of const char*

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 8 12:47:42 PDT 2020


aaron.ballman added a comment.

I think the change is safe to make, but I'm slightly uncomfortable with it because storing a `StringRef` is a somewhat questionable practice given that it's non-owning and it has converting constructors from dangerous types like `std::string`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83402/new/

https://reviews.llvm.org/D83402





More information about the cfe-commits mailing list