[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 8 06:44:56 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:820
+      // A postfix unary operator is declared as taking two operands. The
+      // second operand is used to differ from its prefix counterpart. In the
+      // semantic AST this "phantom" operand is represented as a
----------------
"is used to distinguish"


================
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:823
+      // `IntegerLiteral` with invalid `SourceLocation`. We skip visiting this
+      // operand because we are not able to generate a syntax node from a
+      // semantic node with an invalid `SourceLocation`.
----------------
"... because does not correspond to anything written in the source code"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82954/new/

https://reviews.llvm.org/D82954





More information about the cfe-commits mailing list