[PATCH] D83055: [clang][Driver] Fix tool path priority test failures
David Spickett via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 8 06:37:19 PDT 2020
DavidSpickett added a comment.
For the record my logic here is that I could change the tool names to use the same name as --version. However that will break whatever mips toolchain needed this code in the first place. (https://reviews.llvm.org/D13340?id=36227#inline-108606)
This default triple lookup code had some support to be removed anyway, so I'd rather patch up this test first before doing so. So that it's easier to roll back if there are still users of it. Having tests of the existing behaviour is a good thing and I don't think writing to both potential default triples undermines that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83055/new/
https://reviews.llvm.org/D83055
More information about the cfe-commits
mailing list