[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

Djordje Todorovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 8 05:59:35 PDT 2020


djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:855
 
+class ClangCustomPassManager : public legacy::PassManager {
+public:
----------------
djtodoro wrote:
> vsk wrote:
> > Please factor out OptCustomPassManager from opt and generalize it so it can be used by both opt and clang. That should help ensure that extensions and bug fixes are only made to one custom 'debugify' pass manager.
> I'll try that with the latest code. I remember I've tried it once, but I ended up moving it into the IR library (since we need to link it within legacy pass manager).
Hi @vsk, I've posted the patch as D83391. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82547/new/

https://reviews.llvm.org/D82547





More information about the cfe-commits mailing list