[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 8 02:08:29 PDT 2020


eduucaldas added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2192
       R"cpp(
+class osstream {};
 struct X {
----------------
gribozavr2 wrote:
> I don't think we need a separate class to show the left shift operator. The declaration below can be:
> 
> ```
>   friend X operator<<(X&, const X&);
> ```
If we don't bother much about "realistic" operator declarations we could drop all the `friend` and declare every operator in their most concise form. WDYT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82954/new/

https://reviews.llvm.org/D82954





More information about the cfe-commits mailing list