[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute
Qiu Chaofan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 7 20:24:19 PDT 2020
qiucf added a comment.
Thanks for this patch!
If I understand correctly, only `isEmptyRecord`/`isEmptyField` and places checking any field is zero bit-width may need change for this? Since `isSingleElementStruct` and `isHomogeneousAggregate` just use them to skip empty fields in aggregate. I didn't see direct checking for empty fields on PowerPC. So all change needed on PPC seems to be generic. By enabling `AllowNoUniqueAddr` in these methods, case in https://lists.llvm.org/pipermail/llvm-dev/2020-July/143141.html can be correctly recognized as homogeneous aggregate.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81583/new/
https://reviews.llvm.org/D81583
More information about the cfe-commits
mailing list