[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 7 17:13:34 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.

LGTM. @lebedev.ri ?



================
Comment at: llvm/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp:227
   }
-
-  if (!AAPtr)
-    return false;
-
-  // Sign extend the offset to 64 bits (so that it is like all of the other
-  // expressions).
-  unsigned OffSCEVBits = OffSCEV->getType()->getPrimitiveSizeInBits();
-  if (OffSCEVBits < 64)
-    OffSCEV = SE->getSignExtendExpr(OffSCEV, Int64Ty);
-  else if (OffSCEVBits > 64)
-    return false;
-
-  AAPtr = AAPtr->stripPointerCasts();
-  return true;
+  return false;
 }
----------------
Early exit please.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71739/new/

https://reviews.llvm.org/D71739





More information about the cfe-commits mailing list