[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 7 15:55:37 PDT 2020


MaskRay added a comment.

I still haven't seen a strong argument keeping a command line option `-enable-npm-call-graph-profile`. Asked in D62627 <https://reviews.llvm.org/D62627>.

`Opts.getProfileUse() != CodeGenOptions::ProfileNone ` in

  Opts.CallGraphProfile = Opts.getProfileUse() != CodeGenOptions::ProfileNone &&
                            !Opts.DisableIntegratedAS;

is redundant. CGProfile.cpp is a no-op if no function provides `getEntryFreq()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83013/new/

https://reviews.llvm.org/D83013





More information about the cfe-commits mailing list