[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

Tue Jul 7 11:14:07 PDT 2020

ABataev added inline comments.

================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787
+  if (getLangOpts().OpenMP < 51 && Kind == OMPC_default &&
+      static_cast<DefaultKind>(Val.getValue().Type) ==
+          OMP_DEFAULT_firstprivate) {
----------------
atmnpatel wrote:
> ABataev wrote:
> > atmnpatel wrote:
> > > ABataev wrote:
> > > > ABataev wrote:
> > > > > No need for cast here. 
> > > > Still no need for the cast
> > > Sorry, I saw that before and checked if I could remove it and I can't. Val.getValue().Type is an unsigned int and the other is an enum.
> > This enum should be converted to `int` implicitly, no?
> When we moved the definition of this enum over from clang to llvm, we converted them to strongly typed enums.
I see. Ok then, leave it as is

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75591/new/

https://reviews.llvm.org/D75591