[PATCH] D83233: [clangd] Enable reading config from files by default.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked 4 inline comments as done.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:436
+        "Project config is from a .clangd file in the project directory.\n"
+        "User config is from clangd/config.yaml in the following directories:\n"
+        "\tWindows: %USERPROFILE%\\AppData\\Local\n"
----------------
hokein wrote:
> nit: maybe worth mentioning that the user config has higher privilege.
I think this is the sort of detail best left to the actual documentation.
I've added a... forward declaration of that documentation here, to the URL where it will soon exist.


================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:700
+    ProviderStack.push_back(
+        config::Provider::fromAncestorRelativeYAMLFiles(".clangd", TFS));
+    llvm::SmallString<256> UserConfig;
----------------
kadircet wrote:
> should we first update the background index storage location?
This is done. (There will still be old .clangd directories around, but that will ~always be true)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83233/new/

https://reviews.llvm.org/D83233