[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

[serge via Phabricator via cfe-commits]

serge-sans-paille added a comment.

Some nit-picking, lgtm otherwise. Please wait for @calixte review though :-)



================
Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49
   dlerror();
-  void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush");
-  if (gcov_flush1 == NULL) {
-    fprintf(stderr, "unable to find __gcov_flush in func.shared': %s\n", dlerror());
+  void (*gcov_reset1)() = (void (*)())dlsym(f1_handle, "__gcov_reset");
+  if (gcov_reset1 == NULL) {
----------------
Do we also need to test gcov_flush symbol here too?


================
Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c.gcov:56
+// CHECK-NEXT:        1:   50:  if (gcov_reset1 == NULL) {
+// CHECK-NEXT:    #####:   51:    fprintf(stderr, "unable to find __gcov_reset in func.shared': %s\n", dlerror());
 // CHECK-NEXT:    #####:   52:    return EXIT_FAILURE;
----------------
Same question here, what about gcov_flush symbol?


================
Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main_three-libs.c.gcov:55
+// CHECK-NEXT:        1:   49:  void (*gcov_reset1)() = (void (*)())dlsym(f1_handle, "__gcov_reset");
+// CHECK-NEXT:        1:   50:  if (gcov_reset1 == NULL) {
+// CHECK-NEXT:    #####:   51:    fprintf(stderr, "unable to find __gcov_reset in func.shared': %s\n", dlerror());
----------------
And here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83149/new/

https://reviews.llvm.org/D83149