[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

Tue Jul 7 06:29:44 PDT 2020

ABataev added a comment.

In D83268#2135930 <https://reviews.llvm.org/D83268#2135930>, @JonChesterfield wrote:

> Aside from the API stability concern this looks uncontentious. Removes dead arguments, generally makes things simpler. Thus LGTM.
>
> @Hahnfeld @ABataev - are you sufficiently persuaded that preserving the current interface is not worth the development cost?

No, I'm not. Long before that, we relied on the API stability and already have some runtime calls marked as deprecated. Especially taking into account, that libomp can be built separately.

================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:42
-  /// *outlined_function, int16_t
-  /// IsOMPRuntimeInitialized);
   OMPRTL_NVPTX__kmpc_kernel_prepare_parallel,
----------------
JonChesterfield wrote:
> ABataev wrote:
> > I think, instead the optimizer can try to detect if the runtime library is used by the kernel and switch this flag to `0` if no runtime calls are used in the kernel. For non-SPMD mode in most cases, the runtime is required, but in some cases, it can be disabled.
> If we can detect that no runtime calls are used, we should be able to do better than passing a different argument. E.g. delete some setup calls.
> 
> Failing that, if we want to pass an argument which says 'actually don't do any work', it shouldn't be the same argument used to check whether the runtime has been initialised.
No, I don't think you can do this in all cases

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83268/new/

https://reviews.llvm.org/D83268