[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Parse/ParseExpr.cpp:1944-1951
+              if (StrideExpr && !StrideExpr->isValueDependent() &&
+                  (!StrideExpr->isEvaluatable(Actions.getASTContext()) ||
+                   (StrideExpr->EvaluateAsInt(Result, Actions.getASTContext()) &&
+                    !Result.Val.getInt().isOneValue()))) {
+                Diag(Tok, diag::err_omp_array_section_stride_only_zero_or_one)
+                  << getOpenMPClauseName(OMPClauseKind)
+                  << StrideExpr->getSourceRange();
----------------
No, for non-to/from clauses the stride expression should not be allowed at all if I read the standard correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82800/new/

https://reviews.llvm.org/D82800