[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 6 14:02:46 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:556-557
+  // -fld-path= takes precedence over -fuse-ld= and specifies the executable
+  // name. PATH is consulted if the value does not contain /. -B is
+  // intentionally ignored.
+  if (const Arg *A = Args.getLastArg(options::OPT_fld_path_EQ)) {
----------------
MaskRay wrote:
> jyknight wrote:
> > Shouldn't this use -B paths? Why do we want to ignore them?
> If the value is relative, respect -Bprefix and COMPILER_PATH? (COMPILER is currently not well supported in clang IIUC)
D80660's need is an option relative to the current working directory...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83015/new/

https://reviews.llvm.org/D83015





More information about the cfe-commits mailing list