[PATCH] D83114: [clang] Fix the incorrect dependence bits for DependentExtIntType.

[Erich Keane via Phabricator via cfe-commits]

erichkeane accepted this revision.
erichkeane added inline comments.


================
Comment at: clang/lib/AST/Type.cpp:356
-                    : TypeDependence::None) |
-               (NumBitsExpr->containsUnexpandedParameterPack()
-                    ? TypeDependence::VariablyModified
----------------
sammccall wrote:
> @erichkeane was there any intent behind translating "num bits contains unexpanded pack" into "extint is variably modified", or was this an oversight? (My guess is the latter, just want to double check)
Ah, I think this was a result of a messy/not completely understood rebase.  The 'toTypeDependence' parts appeared in the middle of my review, so I must have just merged the change incorrectly.

This patch seems like the right thing.  Thanks! 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83114/new/

https://reviews.llvm.org/D83114