[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 6 12:53:22 PDT 2020


steakhal added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:267
   BinaryOperatorKind OK = BO->getOpcode();
-  SVal RVal = State->getSVal(BO->getRHS(), C.getLocationContext());
+  Expr *LHS = BO->getLHS();
+  Expr *RHS = BO->getRHS();
----------------
You should probably use const where applicable.
Especially where the refs value depends on a condition operator (eg. few lines below) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83190/new/

https://reviews.llvm.org/D83190





More information about the cfe-commits mailing list