[PATCH] D83183: [clang] Rework how and when APValues are dumped

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: clang/test/Import/switch-stmt/test.cpp:8
 // CHECK-NEXT: ConstantExpr
+// CHECK-NEXT: value: Int 1
 // CHECK-NEXT: IntegerLiteral
----------------
riccibruno wrote:
> aaron.ballman wrote:
> > I sort of wonder whether we want both the text and the JSON dumpers to dump these as: `value(type): <val>`, as that seems like it produces results that are a bit more well-structured. WDYT?
> I'm not sure I follow. The `value` is just a label for the child of the `VarDecl`.
> If you look at a more complex example such as:
> ```
> VarDecl {{.*}} <col:{{.*}}, col:{{.*}}> col:{{.*}} s4 'const S4'
> |-value: Struct
> | |-base: Struct
> | | `-fields: Int 0, Union .j Int 0
> | |-fields: Int 1, Int 2, Int 3
> | |-field: Struct
> | `-fields: Int 4, Int 5, Int 6
> ```
> 
> There is no other `value` label.
Ah, I was misunderstanding the ouput.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83183/new/

https://reviews.llvm.org/D83183