[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 5 17:35:54 PDT 2020


echristo added reviewers: chandlerc, asbirlea.
echristo added a comment.

Adding Chandler and Alina here as well.

In general, I don't think that this is such a great idea. Being able to have this sort of thing work more reliably is one of the reasons for the new pass manager. I think I'd like to see this split out into an old versus new pass manager pass to avoid the difficulty of cleaning this up after we finish migrating llvm to the new pass manager. This also seems to add some technical debt around options and other enablement which is also less than ideal. Is this compelling to add right now versus finishing work migrating llvm completely to the new pass manager and removing the old one? From speaking with Alina I think that work should be done in a short while.

Thanks.

-eric


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83013/new/

https://reviews.llvm.org/D83013





More information about the cfe-commits mailing list