[PATCH] D83178: [clangd] Send EOF before resetting diagnostics consumer

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 5 16:00:21 PDT 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:347
       // FIXME: the PP callbacks skip the entire preamble.
       // Checks that want to see #includes in the main file do not see them.
       Check->registerPPCallbacks(Clang->getSourceManager(), PP, PP);
----------------
Not directly related to this, but surely this comment is redundant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83178/new/

https://reviews.llvm.org/D83178





More information about the cfe-commits mailing list