[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1235
 
+  // Do not use AIX special alignment if current base is not the first member or
+  // the struct is not a union.
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > Suggestion:
> > ```
> >   // AIX `power` alignment does not apply the preferred alignment for non-union
> >   // classes if the source of the alignment (the current base in this context)
> >   // follows introduction of the first member with allocated space.
> > ```
> Adjustment to my suggestion:
> s/first member with allocated space/first subobject with exclusively allocated space/;
Add:
[ ... ] or zero-extent array.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79719/new/

https://reviews.llvm.org/D79719