[PATCH] D82677: [Clang] Handle AIX Include management in the driver
Steven Wan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 3 11:52:36 PDT 2020
stevewan accepted this revision.
stevewan added a comment.
LGTM with minor nit.
I took a look at the failed tests in premerge checks, they didn't seem to be related, but please double check before you commit.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195
+ // Return if -nostdlibinc is specified as a driver option.
+ if (DriverArgs.hasArg(options::OPT_nostdlibinc))
+ return;
----------------
Can we rewrite this block of code so that it's in consistent with the previous one?
```
if (!DriverArgs.hasArg(options::OPT_nostdlibinc)) {
// Add <sysroot>/usr/include.
SmallString<128> UP(Sysroot);
path::append(UP, "/usr/include");
addSystemInclude(DriverArgs, CC1Args, UP.str());
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82677/new/
https://reviews.llvm.org/D82677
More information about the cfe-commits
mailing list