[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added inline comments.


================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:3628
 
+  // FIXME: This may not be the best approach, as the correct type (including
+  // address space) is available in D, but the type in D may not be reliable
----------------
Is this still an issue with your new patch? I presume deducing the address space early would still be better in general but it seems not to play well with the way the template instantiation is implemented currently. Although it might generally be safer not to deduce anything for templates until the final instantiation is done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82781/new/

https://reviews.llvm.org/D82781