[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library
Balázs Kéri via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 3 04:17:01 PDT 2020
balazske added a comment.
Basically this looks good in the current way too, but I can only assume that the code was copied correctly. A rule could be that the `CheckerRegistryData` is manipulated only by `CheckerRegistry` but get or print functions can be in `CheckerRegistryData`.
================
Comment at: clang/unittests/StaticAnalyzer/CallEventTest.cpp:13
#include "clang/Frontend/CompilerInstance.h"
+#include "clang/StaticAnalyzer/Core/AnalyzerOptions.h"
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
----------------
This line seems to be not needed here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82585/new/
https://reviews.llvm.org/D82585
More information about the cfe-commits
mailing list