[PATCH] D83074: [clang] Check ValueDependent instead of InstantiationDependent before executing the align expr for builtin align functions.

Alexander Richardson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 2 16:13:18 PDT 2020


arichardson accepted this revision.
arichardson added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/SemaCXX/builtin-align-cxx.cpp:40
 
 template <typename T>
 void test_incorrect_alignment_without_instatiation(T value) {
----------------
Could also change this to `template <typename T, long A = 31>` and add another ` __builtin_align_up(array, A)` but I'm not sure whether that increases test coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83074/new/

https://reviews.llvm.org/D83074





More information about the cfe-commits mailing list