[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

Thu Jul 2 13:31:08 PDT 2020

jdoerfert added a comment.

In D78478#2128926 <https://reviews.llvm.org/D78478#2128926>, @arichardson wrote:

> In D78478#2128604 <https://reviews.llvm.org/D78478#2128604>, @MaskRay wrote:
>
> > The idea look good to me, but I want some opinions on the name `UTC_ARGS` (I can't help associating it with Coordinated Universal Time). Adding some folks who may have opinions: @greened @lebedev.ri  @RKSimon @spatel  @xbolva00
>
>
> I agree that UTC_ARGS could be a bit confusing. However, there are currently 145 UTC_ARGS uses in tests/Transforms and I'd rather not update them as part of this change.
>
> I feel that changing the name should be a separate change that can be committed after this patch.

Yes, please. The name is my fault, but naming things is hard :(

@MaskRay If you have an alternative name, I propose a `sed -e/UTC_ARGS/.../` patch, maybe with a check in here warning if UTC_ARGS is used.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78478/new/

https://reviews.llvm.org/D78478