[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions
Akira Hatanaka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 2 13:31:07 PDT 2020
ahatanak added a comment.
After-full-expression cleanup looks fine to me. `pushCleanupAfterFullExpr` sets the flags and saves the values when it's in a conditional branch.
I think ideally we shouldn't have to clean up anything in the true expression when the false expression throws, but I wasn't able to come up with an easy way to make IRGen avoid that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82999/new/
https://reviews.llvm.org/D82999
More information about the cfe-commits
mailing list