[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases
Bruno Ricci via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 1 16:14:20 PDT 2020
riccibruno added a comment.
> Yes, I think that my patch just traded-off a bug for another bug. What about the following instead:
>
> Initially zero the `Stmt *` for the body, then when the body is needed (either with `getBody` or with `children`)
> populate it if needed from the call operator. This is what was done before with `getBody`.
>
> This preserve the benefit of having a lazily deserialized body while being a simple fix.
>
> Thoughts? Am I missing something?
>
> If not I can cook-up a patch either tonight or tomorrow.
D83009 <https://reviews.llvm.org/D83009>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82940/new/
https://reviews.llvm.org/D82940
More information about the cfe-commits
mailing list