[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source
Shafik Yaghmour via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 1 16:14:12 PDT 2020
shafik marked an inline comment as done.
shafik added a subscriber: rsmith.
shafik added inline comments.
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1190
if (UseExternalLayout) {
- // FIXME: This appears to be reversed.
if (Base->IsVirtual)
----------------
@rsmith you were correct, this was indeed reversed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83008/new/
https://reviews.llvm.org/D83008
More information about the cfe-commits
mailing list