[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

Wed Jul 1 12:59:28 PDT 2020

thakis added inline comments.

================
Comment at: clang/test/CoverageMapping/coroutine.cpp:1
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping %s | FileCheck %s
+
----------------
Since this line is missing an -o /dev/null, it writes a .ll file into the test directory, which lit tries to run as test next time, causing check-clang to fail: http://45.33.8.238/linux/21841/step_7.txt

Please add `-o /dev/null`, and please also add a `RUN: rm -f %S/coroutine.ll` to clean up bots (with a fixme to remove that rm line once it's been in the tree for a week or so)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82928/new/

https://reviews.llvm.org/D82928