[PATCH] D82908: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x
Francesco Petrogalli via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 1 12:59:25 PDT 2020
fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.
LGTM, thank you.
================
Comment at: clang/utils/TableGen/SveEmitter.cpp:1265-1279
+ OS << "#if defined(__ARM_FEATURE_SVE_BF16)\n";
+ OS << "#define svcvtnt_bf16_x svcvtnt_bf16_m\n";
+ OS << "#define svcvtnt_bf16_f32_x svcvtnt_bf16_f32_m\n";
+ OS << "#endif /*__ARM_FEATURE_SVE_BF16 */\n\n";
+
OS << "#if defined(__ARM_FEATURE_SVE2)\n";
OS << "#define svcvtnt_f16_x svcvtnt_f16_m\n";
----------------
nit: worth adding a comment in the emitter explaining why these redirections are needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82908/new/
https://reviews.llvm.org/D82908
More information about the cfe-commits
mailing list