[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 1 12:27:00 PDT 2020
rsmith accepted this revision.
rsmith added a comment.
This introduces a non-uniformity between `RecursiveASTVisitor` and `StmtVisitor`. `StmtVisitor` contains matching logic to treat the various kinds of unary and binary operators as if they were distinct AST node kinds, and that functionality is used much more heavily throughout Clang. Given that, I don't think this change necessarily improves big-picture uniformity, but the reduction in complexity and binary size still seem sufficiently compelling to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82921/new/
https://reviews.llvm.org/D82921
More information about the cfe-commits
mailing list