[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 1 08:37:57 PDT 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:125
+    CheckFactories.registerCheck<NoEscapeCheck>(
+        "bugprone-no-escape");
     CheckFactories.registerCheck<NotNullTerminatedResultCheck>(
----------------
ellis wrote:
> Not sure if we want to lint this line because it was generated by `clang-tidy/add_new_check.py` and every other `registerCheck` line is formatted in the same way.
They should be formatted, but we don't pipe the changes through clang-format in the `add_new_check.py` script. only 8/21 clang-tidy module files are incorrectly formatted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82904/new/

https://reviews.llvm.org/D82904





More information about the cfe-commits mailing list