[PATCH] D82944: [clangd] Switch FindSymbolsTests to use TestTU

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

LG, thanks!



================
Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:47
 
-ClangdServer::Options optsForTests() {
-  auto ServerOpts = ClangdServer::optsForTest();
-  ServerOpts.WorkspaceRoot = testRoot();
-  ServerOpts.BuildDynamicSymbolIndex = true;
-  return ServerOpts;
-}
-
 class WorkspaceSymbolsTest : public ::testing::Test {
 protected:
----------------
I think we should probably just get rid of this fixture in favor of using TestTU directly (maybe keep getSymbols as a standalone function).
Fine not to do that in this patch though.


================
Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:300
 namespace {
 class DocumentSymbolsTest : public ::testing::Test {
 protected:
----------------
and similar with this one


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82944/new/

https://reviews.llvm.org/D82944