[PATCH] D82930: [HIP] Fix rocm detection

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 1 07:00:24 PDT 2020


arsenm added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167
+    llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> VersionFile =
+        FS.getBufferForFile(BinPath + "/.hipVersion");
+    if (!VersionFile)
----------------
I don't think the detection should fail if this is missing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82930/new/

https://reviews.llvm.org/D82930





More information about the cfe-commits mailing list