[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 1 04:17:21 PDT 2020
MyDeveloperDay marked 3 inline comments as done.
MyDeveloperDay added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:13540
CHECK_PARSE_BOOL(AlignConsecutiveMacros);
+ CHECK_PARSE_BOOL(AlwaysBreakBeforeConceptDeclarations);
CHECK_PARSE_BOOL(AllowAllArgumentsOnNextLine);
----------------
curdeius wrote:
> Format: leading whitespace. Should it be in the same "group" as `AlignConsecutiveMacros`?
I might be misunderstanding your comment, but the list should alphabetic but now I realize it should be after the `Allows`
================
Comment at: clang/unittests/Format/FormatTest.cpp:16745
+ " ::std::is_copy_constructable<T> and "
+ "::std::is_move_constructable<T> and\n"
+ " requires (T c) {\n"
----------------
curdeius wrote:
> Isn't it a strange indentation?
there is no newline on the line above, but I clang-format the tests so it wraps it, I know visually its confusing
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79773/new/
https://reviews.llvm.org/D79773
More information about the cfe-commits
mailing list