[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 23:57:38 PDT 2020


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

+1 to the complexity argument, and also for conceptual complexity: there's a lot of value in RAV being regular and predictable given that both its implementation and the AST itself are complex.

I think this should be mentioned in the release notes, as I think it will silently change the behavior of programs that are using these hooks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82921/new/

https://reviews.llvm.org/D82921





More information about the cfe-commits mailing list