[PATCH] D82740: [libclang]: check validity before visiting Stmt node

Milian Wolff via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 23:57:37 PDT 2020


milianw added a comment.

@jkorous how would you use a debugger (would be GDB for me) to find the source - I would have to use RR or something like that to see why and where the invalid node is added, no?

I also don't have the breaking code at hand anymore, I can try to come up with a way to reproduce it, but as I said it was very non-intuitive and in a large file. I think it was related to parse errors in a statement for a variable that was then captured in a lambda - but that's just a hunch I got from the backtrace so far.

Generally, it's not very straight forward to build a reduced crash test for clang-c. Maybe one could use c-reduce with a minimal visitor... And preprocess the file to have it standalone. I'll see if I get a chance to look into this any time soon, I doubt it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82740/new/

https://reviews.llvm.org/D82740





More information about the cfe-commits mailing list